Fix Qt scrollbar grippers 1.1: Fix control detection #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we attempted to draw the gripper overlay for any control that existed, not just scrollbars. This is because the control theme opened by the HTHEME was not checked. Now, we only try drawing scrollbar grippers if we know the control itself is a scrollbar. Signed-off-by: Isabella <kawapure@gmail.com>
Signed-off-by: Isabella <kawapure@gmail.com>
Signed-off-by: Isabella <kawapure@gmail.com>
m417z
reviewed
Oct 25, 2024
// uxtheme!GetThemeClass exported entry 74
HRESULT STDMETHODCALLTYPE GetThemeClass(HTHEME hTheme, LPCWSTR pszClassIdList, int cchClass);You can actually use GetThemeClass to get the class name of HTHEME without the need to hook additional functions. |
Thank you for the information. This is very useful. I tried to find similar functionality but I failed to find such a function looking in IDA myself. |
Detection of the theme class has been moved to use the undocumented GetThemeClass export from UXTheme rather than hooking OpenThemeData and CloseThemeData and keeping track of theme handles manually. Signed-off-by: Isabella <kawapure@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we attempted to draw the gripper overlay for any control that existed, not just scrollbars. This is because the control theme opened by the HTHEME was not checked. Now, we only try drawing scrollbar grippers if we know the control itself is a scrollbar.